Add more backing-agnostic methods to Root #17934
Open
+125
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-bypass-changelog |
glyh
approved these changes
Oct 13, 2025
| } ) | ||
|
|
||
| let create_checkpoint_with_directory t ~directory_name = | ||
| let backing_type = |
There was a problem hiding this comment.
Nit: use this aux function defined in this file
let backing_of_t = function
| Stable_db _ ->
Config.Stable_db
| Converting_db _ ->
Converting_db
| [empty_hardfork_db]. The accounts are set in the target database in chunks | ||
| so the daemon is still responsive during this operation; the daemon would | ||
| otherwise stop everything as it hashed every account in the list. *) | ||
| let chunked_migration ?(chunk_size = 1 lsl 6) stable_locations_and_accounts |
There was a problem hiding this comment.
Why not use OCaml threads? Even if we don't have OCaml 5 level of thread support, this is still something?
| | Stable_db db -> | ||
| let directory_name = | ||
| Stable_db.get_directory db | ||
| |> Option.value_exn |
| ~depth:ledger_depth ~assert_synced:true () | ||
| in | ||
| L.Root.close converting_root ; | ||
| Deferred.unit ) |
There was a problem hiding this comment.
Might want a check to ensure there's no "long async job" happening? So to keep up with the guarantee "gradual"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be helpful for code organization purposes when generating the hard fork config to be able to copy root ledgers (via checkpointing), convert a stable-database-backed root to a converting root, and to (unsafely) view the components of a root ledger.
I've added a test of the
make_convertingmethod in particular, which converts a stable root to a converting one by migrating the stable database in chunks.These methods were pulled out of #17816; that PR now depends on this one.
Closes: #17751